Beware of Shady Plugin Seller/Thief - Revision history

Yanfly at 21:30, 26 October 2019

2019-10-26T21:30:09Z

Yanfly at 20:38, 26 October 2019

2019-10-26T20:38:03Z

Yanfly at 20:34, 26 October 2019

2019-10-26T20:34:03Z

Yanfly at 20:32, 26 October 2019

2019-10-26T20:32:55Z

Yanfly at 05:30, 26 October 2019

2019-10-26T05:30:32Z

Yanfly: Created page with "400px A plugin seller by the name of Isabella Ava (aka master2015hp) was questioned to clarify why a [https://master2015hp.itch.io/olivia-victory-addo..."

2019-10-26T05:21:19Z

Created page with "400px A plugin seller by the name of Isabella Ava (aka master2015hp) was questioned to clarify why a [https://master2015hp.itch.io/olivia-victory-addo..."

New page

[[File:NoIsabella.png|400px]]

A plugin seller by the name of Isabella Ava (aka master2015hp) was questioned to clarify why a [https://master2015hp.itch.io/olivia-victory-addon certain plugin] had the overly similar appearance of the [[Yanfly Engine Plugins]] library's [[Aftermath Level Up (YEP)|Aftermath Level Up]].

Here are the comparisons:

[[File:IsabellaCompare.png|400px]]

What it looks like, to quote some other users, is that parts of the [[Aftermath Level Up (YEP)|Aftermath Level Up]] plugin is cut and pasted on top of [[Victory Sequence UI (Olivia)|Olivia's Victory UI]]. It's one thing if the code was made entirely by themselves, but there is a distinct way the numbers appear in the Yanfly [[Aftermath Level Up (YEP)|Aftermath Level Up]] plugin that also resurfaces on the suspect's. No permission has been asked from the individual nor granted to the individual to resell the code either.

When the suspect was probed as to why this is, here is the response:

[[File:IsabellaResponse.png]]

To which, [[Atelier Irina|Irina]] mentions that [[Victory Sequence UI (Olivia)|Olivia's Victory UI]] cannot exist in the same project as [[Victory Aftermath (YEP)|Yanfly's Victory Aftermath]] without conflicts. As [[Aftermath Level Up (YEP)|Aftermath Level Up]] is an extension plugin of [[Victory Aftermath (YEP)|Yanfly's Victory Aftermath]], there's no way for the suspected plugin to be able to call from it, which means the code has be have been taken from [[Aftermath Level Up (YEP)|Aftermath Level Up]].

When Yanfly asked the individual if the code can be compared, the individual responded as such:

[[File:IsabellaResponse2.png]]

Had the individual actually crafted the code themselves, there'd be nothing to be afraid of here, and they'd have cleared themselves of suspicion. Instead, leaving such a nasty message in hopes of a desperate sale puts them in the limelight all the more.

Other suspicious plugins of theirs also include the [https://master2015hp.itch.io/addon-yepgridfreedoodads "addon for YEP Grid Free Doodad"], which as far as Team Yanfly can tell, only does as far as changing up some shortcut keys to perform other actions by [[Grid-Free Doodads (YEP)|Yanfly's code]]. This plugin of theirs is also being sold.

Another one being sold is their [https://master2015hp.itch.io/persistent-switches Persistent Switches], which (though unconfirmed) may have been an alteration of [https://endlessillusoft.com/eis-persistent-switches/ Endless Illusion Software's Persistent Switches].

We '''STRONGLY''' encourage you users to stay away from this "plugin developer" as their actions and products are extremely suspicious.

← Older revision		Revision as of 21:30, 26 October 2019
Line 157:		Line 157:

	The only real differences is that there's errors in Ava's code (since widths and heights are calculated like such) and they automatically position everything to left text alignment. But other than that, the same.		The only real differences is that there's errors in Ava's code (since widths and heights are calculated like such) and they automatically position everything to left text alignment. But other than that, the same.
		+
		+	It's easy to say that this would be the general way of handling it, but then, you'd have to consider the point I made before: the strange for loop of going from 0 to 9 instead of the norm. In short, the more questions you ask about the oddities, the more awkward it gets when trying to figure out where the reasoning behind it comes from (aka from YEP Aftermath Level Up).

	There's more examples found in the code like with the skill window, but I'll spare you all the details since that's some other levels and layers that I'd have to dig through and all that'd accomplish is beating a dead horse.		There's more examples found in the code like with the skill window, but I'll spare you all the details since that's some other levels and layers that I'd have to dig through and all that'd accomplish is beating a dead horse.

@@ Line 134: / Line 134: @@
 <pre>
-Window_VictoryLevelUp.prototype.drawItem = function(paramId, x, y, ) {
+Window_VictoryLevelUp.prototype.drawItem = function(paramId, x, y) {
 	var arrow = '\u2192';
 	var index = paramId - 1;

@@ Line 113: / Line 113: @@
 </pre>
-Where in which, the standard thing to do would be to draw the level first, then loop 0 through 7 for the parameters? Why follow it the way I did it? If it's because "there's only so many ways to do x", this is the usual excuse given by anyone who plagiarizes from another. The truth is, there's many ways to handle this situation, yet, they choose to do it like mine.
+Where in which, the standard thing to do would be to draw the level first, then loop 0 through 7 for the parameters? Why follow it the way I did it? If it's because "there's only so many ways to do x", this is the usual excuse given by anyone who plagiarizes from another. The truth is, there's many ways to handle this code, yet, they choose to do it like mine with the same strange loop I've made. Wonder why?
 Now, let's go take a look back at the code comparisons. Now, what they did this time was the complete opposite of what I did. Where I wrote things out in an object oriented manner, they decided to consolidate it into one thing. Why? Perhaps to look different? Who knows. But let's see:

← Older revision		Revision as of 20:32, 26 October 2019
Line 20:		Line 20:

	Had the individual actually crafted the code themselves, there'd be nothing to be afraid of here, and they'd have cleared themselves of suspicion. Instead, leaving such a nasty message in hopes of a desperate sale puts them in the limelight all the more.		Had the individual actually crafted the code themselves, there'd be nothing to be afraid of here, and they'd have cleared themselves of suspicion. Instead, leaving such a nasty message in hopes of a desperate sale puts them in the limelight all the more.
		+
		+	<hr>
		+
		+	Now with code comparisons:
		+
		+	YEP:
		+
		+	<pre>
		+	Window_VictoryLevelUp.prototype.refresh = function() {
		+	this.contents.clear();
		+	var bitmap = ImageManager.loadFace(this._actor.faceName());
		+	if (bitmap.width <= 0) return setTimeout(this.refresh.bind(this), 5);
		+	this.resetFontSettings();
		+	this.resetTextColor();
		+	this.drawActorAppearance();
		+	this.drawDarkRects();
		+	this.drawStatChanges();
		+	this.drawLearnedSkillsTitle();
		+	};
		+	</pre>
		+
		+	Here is theirs:
		+
		+	<pre>
		+	Window_ActorLevelUp.prototype.refresh = function() {
		+	this.contents.clear();
		+	this.drawBackground();
		+	this.drawBackgroundRewardStrip(actorStat_x - 20, actorStat_y - this.lineHeight(), actorStat_w - 100, 100);
		+	this.contents.fontSize = cFontSize;
		+	this.drawText(str1, actorStat_x - 20 + ckeIndent * 5, actorStat_y - this.lineHeight(), actorStat_w - 100, this.lineHeight(), 'left');
		+	//this.drawForeground();
		+	};
		+	</pre>
		+
		+	Looks innocent enough, right?
		+
		+	But ever heard that phrase, "to hide a body, you best chop it up into smaller pieces first?"
		+
		+	Turns out they did just that.
		+
		+	<pre>
		+	Window_ActorLevelUp.prototype.createSubWindows = function() {
		+	this.createPortraitWindow();
		+	this.createStatWindow();
		+	this.createContinueWindow();
		+	};
		+	</pre>
		+
		+	They split up the methods across three (unnecessarily) created windows to split up the functions.
		+
		+	Now, let's take a look at how YEP Aftermath Level Up handles drawing each of the parameters:
		+
		+	<pre>
		+	Window_VictoryLevelUp.prototype.drawStatChanges = function() {
		+	this.contents.fontSize = Yanfly.Param.ALUFontSize;
		+	for (var i = 0; i < 9; ++i) {
		+	var rect = this.itemRect(i);
		+	this.drawRightArrow(rect);
		+	this.drawParamName(i, rect);
		+	this.drawCurrentParam(i, rect);
		+	this.drawNewParam(i, rect);
		+	this.drawParamDifference(i, rect);
		+	}
		+	};
		+	</pre>
		+
		+	Keep this in mind that this is not the standard way of looping through all the parameters. This is just the one way I did it, this one particular time for this one particular plugin. There are only 8 parameters out there, which means only numbers 0 through 7 have to be looped.
		+
		+	So then, why is it done here?
		+
		+	<pre>
		+	Window_ActorStats.prototype.createSubWindows = function() {
		+	var statData = "";
		+	for(i = 0; i < 9; i++) {
		+	switch(i) {
		+	case 0: statData = "Level"; break;
		+	case 1: statData = "Max HP"; break;
		+	case 2: statData = "Max MP"; break;
		+	case 3: statData = "ATK"; break;
		+	case 4: statData = "DEF"; break;
		+	case 5: statData = "MAT"; break;
		+	case 6: statData = "MDF"; break;
		+	case 7: statData = "AGI"; break;
		+	case 8: statData = "LUK"; break;
		+	default: statData = "Test";
		+	}
		+	this._subWindows = new Window_SubStats(statData);
		+	this.addChild(this._subWindows);
		+	subStat_y += this.lineHeight();
		+	}
		+	}
		+	</pre>
		+
		+	Where in which, the standard thing to do would be to draw the level first, then loop 0 through 7 for the parameters? Why follow it the way I did it? If it's because "there's only so many ways to do x", this is the usual excuse given by anyone who plagiarizes from another. The truth is, there's many ways to handle this situation, yet, they choose to do it like mine.
		+
		+	Now, let's go take a look back at the code comparisons. Now, what they did this time was the complete opposite of what I did. Where I wrote things out in an object oriented manner, they decided to consolidate it into one thing. Why? Perhaps to look different? Who knows. But let's see:
		+
		+	<pre>
		+	Window_SubStats.prototype.drawData = function(statData){
		+	this.drawText(this.title, ckeIndent, 0, this.width, this.height, 'left');
		+	this.drawText(String(this.valueOld), 150, 0, this.width, this.height, 'left');
		+	if (this.valueOld != this.value) {
		+	this.drawText('→', 200, 0, this.width, this.height, 'left');
		+	this.drawText(String(this.value), 250, 0, this.width, this.height, 'left');
		+	var str = '(+' + String(this.value - this.valueOld) + ')';
		+	this.changeTextColor(this.textColor(3));
		+	this.drawText(str, 300, 0, this.width, this.height, 'left');
		+	}
		+	}
		+	</pre>
		+
		+	These come from the YEP Aftermath Level Up functions, but in a stripped down manner, free of any Plugin Parameter fluff in the code and hard values for the coordinates. Let's see what happens when I do the same, too.
		+
		+	<pre>
		+	Window_VictoryLevelUp.prototype.drawItem = function(paramId, x, y, ) {
		+	var arrow = '\u2192';
		+	var index = paramId - 1;
		+	var newValue = this._actor._postVictoryParams[index];
		+	var diffvalue = newValue - this._actor._preVictoryParams[index];
		+	this.drawText(TextManager.param(index), 0, y, this._paramNameWidth);
		+	this.drawText(this._actor._preVictoryParams[index], 150, y, this._paramValueWidth, 'right');
		+	if (diffvalue !== 0) {
		+	this.drawText(arrow, 200, y, dw, 'center');
		+	this.drawText(this._actor._postVictoryParams[index], 250, y, this._paramValueWidth, 'right');
		+	var text = '(' + (diffValue >= 0 ? '+' : '-') + diffvalue + ')';
		+	this.drawText(text, 300, y, this._bonusValueWidth, 'left');
		+	}
		+	};
		+	</pre>
		+
		+	Looks similar?
		+
		+	Very.
		+
		+	The code I've added there is essentially the last line of all the functions within the previous loop I've made with inserted variables where they have to be and arbitrary numbers from 0 to 300 in increments of 50. Suddenly, it seems pretty close, huh?
		+
		+	The only real differences is that there's errors in Ava's code (since widths and heights are calculated like such) and they automatically position everything to left text alignment. But other than that, the same.
		+
		+	There's more examples found in the code like with the skill window, but I'll spare you all the details since that's some other levels and layers that I'd have to dig through and all that'd accomplish is beating a dead horse.
		+
		+	<hr>

	Other suspicious plugins of theirs also include the [https://master2015hp.itch.io/addon-yepgridfreedoodads "addon for YEP Grid Free Doodad"], which as far as Team Yanfly can tell, only does as far as changing up some shortcut keys to perform other actions by [[Grid-Free Doodads (YEP)\|Yanfly's code]]. This plugin of theirs is also being sold.		Other suspicious plugins of theirs also include the [https://master2015hp.itch.io/addon-yepgridfreedoodads "addon for YEP Grid Free Doodad"], which as far as Team Yanfly can tell, only does as far as changing up some shortcut keys to perform other actions by [[Grid-Free Doodads (YEP)\|Yanfly's code]]. This plugin of theirs is also being sold.

← Older revision		Revision as of 05:30, 26 October 2019
Line 24:		Line 24:

	Another one being sold is their [https://master2015hp.itch.io/persistent-switches Persistent Switches], which (though unconfirmed) may have been an alteration of [https://endlessillusoft.com/eis-persistent-switches/ Endless Illusion Software's Persistent Switches].		Another one being sold is their [https://master2015hp.itch.io/persistent-switches Persistent Switches], which (though unconfirmed) may have been an alteration of [https://endlessillusoft.com/eis-persistent-switches/ Endless Illusion Software's Persistent Switches].
		+
		+	There may be other plugins out there under the same nature.

	We '''STRONGLY''' encourage you users to stay away from this "plugin developer" as their actions and products are extremely suspicious.		We '''STRONGLY''' encourage you users to stay away from this "plugin developer" as their actions and products are extremely suspicious.